-
Notifications
You must be signed in to change notification settings - Fork 97
SSR support #202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
SSR support #202
Conversation
7cba146
to
97ba298
Compare
20086b9
to
ee186a8
Compare
any updates on this? |
any news on this? |
Hi @FallenRiteMonk can you plz help for this? |
@MarouaniALA I'm sorry but currently I'm short on time. |
b83fbe4
to
83cf6f5
Compare
7cb331d
to
a70ba9c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I comment to remove this old pr from my review list
Hi, thank you for your contribution. As we just merged If this PR remains unchanged within 3 months, we will automatically close it. |
Due to lack of time, I wasn't able to test this aproprietly, but this should fix #108.
@quentin-ol since this will not break any existing application, could you please merge this so I can try it easily without having to set up server side rendering (SSR) for your example project.
If not I'll hopefully find some time in near future to test this.
Further on, in combination with the proposal you made in #108 (comment), this could be extended to render a 'alt-img' if rendered on a server, making this module fully SSR capable.