Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rudimentary single-query rate limit #78

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

marcustyphoon
Copy link
Contributor

It's currently not possible to run api.items().all() (which is in the "basic usage" suggestions in the readme) because of a lack of rate limiting and the request count for that single query being over 300 (330 at time of posting).

This obviously isn't how one would solve this for real, but I would imagine the proper way would involve adding features to lets-fetch. But here's how I monkey patched it so I could at least run the command in question.

Copy link
Owner

@queicherius queicherius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting - I've never had an issue running this even on my home server.

I'm not opposed to merging this, but I would need a way to opt-out because the servers gw2efficiency run on are exempt from the rate limiting.

Also super nit, but please start comments with an Uppercase character for my OCD :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants