Conversation
* Add ability to adjust multipler of each mining algo's solution. * Set ADDITION multiplier equal to HYPERIDENTITY.
* fix: refund payment in the QIP sc * set the epoch for the refund * fix: init in the BEGIN_EPOCH * fix: wrong variable name * removed googletest-src * fix: init issue
* QSwap audit fixes * epoch -> tick * audit 2 fixes * include removed * pr rewiev fixes
Issue desciption: #684 (comment)
All non-public functions and variables of contract structs should be protected instead of private in order to allow testing through derived testing classes.
philippwerner
approved these changes
Feb 3, 2026
Contributor
philippwerner
left a comment
philippwerner
left a comment
There was a problem hiding this comment.
Looks good to me. Just a few hints:
- Please remember to mention in the release announcement that the QSWAP state file needs to be extended:
dd if=/dev/zero bs=8 count=1 >> contract0013.199 - I would change "Fix/qip refund payment" to "QIP: fix refund payment"
- "Fix issues in gtest relate to member scope" -> "related to"
- I usually try to sort the items by relevance from the user's point of view (e.g. I would move "Remove all toggles for code that depended on proposals" to the bottom or remove it completely)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.