Merged
Conversation
Collaborator
|
please discuss this change with @fnordspace. he's leading the refactoring project and yesterday we were discussing the option of consolidating these functions in an SC utility lib (or move them to qpi if we see fit) to avoid all this copy-paste code. |
fnordspace
approved these changes
Feb 2, 2026
Contributor
fnordspace
left a comment
fnordspace
left a comment
There was a problem hiding this comment.
LGTM
DateTime is already in QPI, this is an older version, hence probably the best solution for the moment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR ports all date time functions that Nostromo and Qbay cross calling via
QUOTTERY::*this is preparation before new code for qtry getting merged (requested by qtry dev)