Skip to content

Conversation

@juliasilge
Copy link
Collaborator

I called the new package vscode-quarto-utils so that it shows up under vscode-editor and vscode-markdownit in the directory structure, but I am open to a different naming option here. I do think utils is too short.

@juliasilge juliasilge marked this pull request as ready for review November 5, 2025 15:49
@juliasilge
Copy link
Collaborator Author

OK, I think this works now. You can confirm by getting the artifact from the GH action, unzipping, and installing the .vsix.

@cscheid do you have an opinion on the naming of this new little tiny thing? We needed the logic for detecting an R package in both lsp and vscode so we moved it up. I could imagine us putting other small utilities in there in the future.

@juliasilge juliasilge requested a review from lionel- November 5, 2025 15:54
*/

import { isRPackage as isRPackageImpl } from "@utils/r-utils";
import { isRPackage as isRPackageImpl } from "vscode-quarto-utils";
Copy link
Collaborator

@lionel- lionel- Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't seem right for the LSP to depend on a "vscode" module. How about quarto-lsp-utils?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's used elsewhere in the VS Code extension not in functionality that has anything to do with an LSP, so that doesn't seem right either.

Maybe just quarto-utils?

Copy link
Collaborator Author

@juliasilge juliasilge Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or quarto-workspace-utils or extension-utils or shared-utils?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quarto-utils seems good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants