don't prepend delimiter to path #778
Merged
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliasilge
reviewed
Aug 4, 2025
There was a problem hiding this comment.
Great catch, @jforest!
Things are working well for me with this change. Can you add an entry to the CHANGELOG?
Once this is merged in, I can do a release of the extension if we want this fix out ASAP.
|
(oops, we both tried adding to changelog. Sorry! Though I'll keep mine because I think it's more descriptive.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(thanks @jforest, who spotted this in the wild) I think we shouldn't be prepending
path.delimiter + ...to the path. We end up with a path string starting withpath.delimiter, which puts an empty string on the path.