Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the quarkus MongoClients in the liquibase-mongodb extension #46326

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Use the quarkus MongoClients in the liquibase-mongodb extension #46326

merged 1 commit into from
Feb 18, 2025

Conversation

Malandril
Copy link
Contributor

@Malandril Malandril commented Feb 18, 2025 •
edited by geoand
Loading

This PR makes the liquibase-mongodb extension use the quarkus MongoClients to create mongo clients instead of relying on the liquibase logic.

This allows the following:

  • remove all the problems linked to the need of rebuilding connection-string
  • apply the MongoClientCustomizer on the clients
  • Reuse all the mongo clients configuration

@Malandril Malandril mentioned this pull request Feb 18, 2025
Closed
@geoand
Copy link
Contributor

geoand commented Feb 18, 2025

This is really nice!

Can we please remove all the lambdas and method handles from the code?

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 18, 2025 •
edited
Loading

🙈 The PR is closed and the preview is expired.

@Malandril
Copy link
Contributor Author

This is really nice!

Can we please remove all the lambdas and method handles from the code?

Is it because its in a recorder or, just as a general rule it is to be avoided due to the cost ?

@geoand
Copy link
Contributor

geoand commented Feb 18, 2025

We try to avoid lambdas in code that executes at startup

@Malandril Malandril marked this pull request as ready for review February 18, 2025 10:46
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@geoand
Copy link
Contributor

geoand commented Feb 18, 2025

Please squash the commits :)

@geoand
feat: Liquibase use mongo client
240d769 
feat: Try to use a different way

Apply suggestions from code review

Co-authored-by: Georgios Andrianakis <[email protected]>
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Feb 18, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 240d769.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

geoand
geoand approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Feb 18, 2025
@Malandril
Copy link
Contributor Author

Thanks for the help and review!

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Feb 18, 2025 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 240d769.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@geoand geoand merged commit fe56f70 into quarkusio:main Feb 18, 2025
25 checks passed
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Feb 18, 2025
@quarkus-bot quarkus-bot bot added this to the 3.21 - main milestone Feb 18, 2025
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
area/documentation area/liquibase area/mongodb kind/enhancement New feature or request
Projects
None yet
Milestone
3.21 - main
Development

Successfully merging this pull request may close these issues.

Use the quarkus MongoClient in liquibase-mongodb extension
2 participants
@Malandril @geoand