Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a few misplaced @WithConverter #46297

Merged
merged 1 commit into from
Feb 17, 2025
Merged

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Feb 17, 2025

The @WithConverter annotation is different from the @ConvertWith annotation and needs to be placed appropriately on the transformed type.

After this PR, they should all be correctly positioned.

The @WithConverter annotation is different from the @ConvertWith
annotation and needs to be placed appropriately on the transformed type.

After this PR, they should all be correctly positioned.
@gsmet
Copy link
Member Author

gsmet commented Feb 17, 2025

It won't be all backportable as I think some are new in 3.19 but I will backport what makes sense for 3.18.

Copy link

quarkus-bot bot commented Feb 17, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit bc3fe92.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

Copy link

🎊 PR Preview 2df8c69 has been successfully built and deployed to https://quarkus-pr-main-46297-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

Copy link

quarkus-bot bot commented Feb 17, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit bc3fe92.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gsmet gsmet merged commit 338c749 into quarkusio:main Feb 17, 2025
57 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.21 - main milestone Feb 17, 2025
@gsmet gsmet modified the milestones: 3.21 - main, 3.19.0 Feb 18, 2025
@gsmet gsmet modified the milestones: 3.19.0, 3.18.4 Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants