Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qute message bundles: add Message#defaultValue() #46280

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Qute message bundles: add Message#defaultValue() #46280

merged 1 commit into from
Feb 14, 2025
+134 −10

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Feb 14, 2025

@mkouba
Qute message bundles: add Message#defaultValue()
fc03e4f 
- this message template is only used if Message#value() is not specified
and a relevant message template is not defined in a localized file
- resolves quarkusio#46259
@quarkus-bot quarkus-bot bot added area/documentation area/qute The template engine labels Feb 14, 2025
ia3andy
ia3andy approved these changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@ia3andy ia3andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You Roq! :)

@mkouba
Copy link
Contributor Author

mkouba commented Feb 14, 2025

You Roq! :)

🙏

It would be nice if you could test this PR with a roq app!

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Feb 14, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit fc03e4f.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 14, 2025 •
edited
Loading

🙈 The PR is closed and the preview is expired.

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Feb 14, 2025 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit fc03e4f.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

michalvavrik
michalvavrik approved these changes Feb 14, 2025
View reviewed changes
Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition, changes LGTM.

@mkouba mkouba merged commit 9fcb390 into quarkusio:main Feb 14, 2025
29 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.21 - main milestone Feb 14, 2025
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ia3andy ia3andy ia3andy approved these changes

@michalvavrik michalvavrik michalvavrik approved these changes

Assignees
No one assigned
Labels
area/documentation area/qute The template engine kind/enhancement New feature or request
Projects
None yet
Milestone
3.21 - main
Development

Successfully merging this pull request may close these issues.

Allow to provide a default overridable value for Qute @Message
3 participants
@mkouba @ia3andy @michalvavrik