Merge pull request #46226 from Sanne/EnhancementCleanup

Cleanup Hibernate ORM bytecode enhancer
quarkusio · Feb 13, 2025 · 22d8b35 · 22d8b35
2 parents 9275057 + d755488
commit 22d8b35
Showing 1 changed file with 11 additions and 40 deletions.
diff --git a/...deployment/src/main/java/io/quarkus/hibernate/orm/deployment/HibernateEntityEnhancer.java b/...deployment/src/main/java/io/quarkus/hibernate/orm/deployment/HibernateEntityEnhancer.java
@@ -17,7 +17,6 @@
 import io.quarkus.hibernate.orm.deployment.integration.QuarkusClassFileLocator;
 import io.quarkus.hibernate.orm.deployment.integration.QuarkusEnhancementContext;
 import net.bytebuddy.ClassFileVersion;
-import net.bytebuddy.dynamic.ClassFileLocator;
 
 /**
  * Used to transform bytecode by registering to
@@ -37,11 +36,15 @@ public final class HibernateEntityEnhancer implements BiFunction<String, ClassVi
             ClassFileVersion.JAVA_V17);
 
     //Choose this set to include Jakarta annotations, basic Java types such as String and Map, Hibernate annotations, and Panache supertypes:
-    private static final CoreTypePool CORE_POOL = new CoreTypePool("jakarta.persistence.", "java.",
+    private static final CoreTypePool CORE_POOL = new CoreTypePool(
+            "java.",
+            "jakarta.",
+            "org.hibernate.bytecode.enhance.spi.",
+            "org.hibernate.engine.spi.",
             "org.hibernate.annotations.",
-            "io.quarkus.hibernate.reactive.panache.", "io.quarkus.hibernate.orm.panache.",
-            "org.hibernate.search.mapper.pojo.mapping.definition.annotation.",
-            "jakarta.validation.constraints.");
+            "io.quarkus.hibernate.reactive.panache.",
+            "io.quarkus.hibernate.orm.panache.",
+            "org.hibernate.search.mapper.pojo.mapping.definition.annotation.");
 
     private final EnhancerHolder enhancerHolder = new EnhancerHolder();
 
@@ -99,46 +102,14 @@ public Enhancer getEnhancer() {
             if (actualEnhancer == null) {
                 synchronized (this) {
                     if (actualEnhancer == null) {
-                        actualEnhancer = PROVIDER.getEnhancer(QuarkusEnhancementContext.INSTANCE, new ThreadsafeLocator());
+                        EnhancerClassLocator enhancerClassLocator = ModelTypePool
+                                .buildModelTypePool(QuarkusClassFileLocator.INSTANCE, CORE_POOL);
+                        actualEnhancer = PROVIDER.getEnhancer(QuarkusEnhancementContext.INSTANCE, enhancerClassLocator);
                     }
                 }
             }
             return actualEnhancer;
         }
     }
 
-    private static final class ThreadsafeLocator implements EnhancerClassLocator {
-
-        final ThreadLocal<EnhancerClassLocator> localLocator = ThreadLocal
-                .withInitial(() -> ModelTypePool.buildModelTypePool(QuarkusClassFileLocator.INSTANCE,
-                        CORE_POOL));
-
-        @Override
-        public void registerClassNameAndBytes(String s, byte[] bytes) {
-            localLocator.get().registerClassNameAndBytes(s, bytes);
-        }
-
-        @Override
-        public void deregisterClassNameAndBytes(String s) {
-            localLocator.get().deregisterClassNameAndBytes(s);
-        }
-
-        @Override
-        public ClassFileLocator asClassFileLocator() {
-            return localLocator.get().asClassFileLocator();
-        }
-
-        @Override
-        public Resolution describe(String s) {
-            return localLocator.get().describe(s);
-        }
-
-        @Override
-        public void clear() {
-            //not essential as it gets discarded, but could help:
-            localLocator.get().clear();
-            localLocator.remove();
-        }
-    }
-
 }