-
Notifications
You must be signed in to change notification settings - Fork 127
Fix #417: address pythonpackage.yml vulnerabilities & do other updates #418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mhucka
wants to merge
17
commits into
quantumlib:master
Choose a base branch
from
mhucka:mh-fix-291
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses the following code scan vulnerability alerts: * https://github.com/quantumlib/ReCirq/security/code-scanning/2 * https://github.com/quantumlib/ReCirq/security/code-scanning/3
This is more modular, and lets the jobs run in parallel.
I'm not sure why this was called pythonpackage.yml, since what it does is do CI checks, and we don't produce Python package releases for ReCirq. So, IMHO it makes sense to rename this to `ci.yaml`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/devops
Concerns continuous integration, workflows, automation, maintenance, dev tools, etc.
area/health
Issues and PRs related to code, repository, or project health
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the following code scan vulnerability alerts:
In additions, it does the following:
flake8
tests into a separate parallel jobmaster
andmain
(in anticipation of renaming the default branch)ci.yaml
to better reflect what it does