Fix mutable_pauli_string.inplace_after() and inplace_before() #7507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7507 +/- ##
==========================================
- Coverage 97.53% 97.49% -0.05%
==========================================
Files 1095 1095
Lines 99016 99009 -7
==========================================
- Hits 96580 96526 -54
- Misses 2436 2483 +47 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hey Nour @NoureldinYosri , could you help take a look at this PR? This is the last pr in fixing #6946. |
cirq-core/cirq/ops/pauli_string.py
Outdated
| flattened_ops = list(op_tree.flatten_to_ops(ops)) | ||
|
|
||
| for op in flattened_ops[::-1]: | ||
| conjugated: cirq.DensePauliString = dense_pauli_string.DensePauliString( |
There was a problem hiding this comment.
maybe conjugates = self.dense(self.qubits) * dense_pauli_string.DensePauliString('I'*len(self.qubits)) should do the trick? ... no need for the logic below
There was a problem hiding this comment.
Good idea! updated.
|
Thanks @NoureldinYosri for the review! Comments applied, could you help take another look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the fix for PauliString.after() #7065, this is the fix for MutablePauliString.
Also deleted the culprit _decompose_into_cliffords helper function that was used by PauliString.after() and MutablePauliString.inplace_after().
Issue: #6946.