Skip to content

Change use of measurements to records in tomography [continued] #7477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 22, 2025

Conversation

KerryZhou1024
Copy link
Contributor

@KerryZhou1024 KerryZhou1024 commented Jul 9, 2025

Bringing PR #7421 across the finish line since the original contributors' internships have concluded. I can't edit the original PR, so forking and opening another PR would be the most efficient.

In the file qubit_characterizations.py, in the function definition of single_qubit_state_tomography, changing the use of measurements to records allows for circuits with multiple key measurements to be supported without throwing an error for having repeated keys

Heavy lifting by
@kygnz
@sgavi4
@abyssaldragonz
@thomasasha

Closes issue #7417 and the original PR #7421

@KerryZhou1024 KerryZhou1024 requested review from mrwojtek, vtomole and a team as code owners July 9, 2025 21:18
@KerryZhou1024 KerryZhou1024 requested a review from mpharrigan July 9, 2025 21:18
Copy link

google-cla bot commented Jul 9, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot added the size: S 10< lines changed <50 label Jul 9, 2025
Copy link

codecov bot commented Jul 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.53%. Comparing base (cd32133) to head (9b318e9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7477      +/-   ##
==========================================
- Coverage   97.53%   97.53%   -0.01%     
==========================================
  Files        1095     1095              
  Lines       99002    99016      +14     
==========================================
+ Hits        96566    96576      +10     
- Misses       2436     2440       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@vtomole vtomole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vtomole
Copy link
Collaborator

vtomole commented Jul 10, 2025

Merging after @maffoo approves.

@KerryZhou1024
Copy link
Contributor Author

Tested the snippet locally and it passed for me!
Screenshot 2025-07-10 at 5 43 05 PM

@vtomole vtomole added this pull request to the merge queue Jul 22, 2025
Merged via the queue into quantumlib:main with commit 315f026 Jul 22, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: S 10< lines changed <50
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants