Allow users to run readout benchmarking with sweep #7435
+684
−198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7435 +/- ##
==========================================
- Coverage 98.69% 97.54% -1.16%
==========================================
Files 1112 1095 -17
Lines 98076 99203 +1127
==========================================
- Hits 96798 96767 -31
- Misses 1278 2436 +1158 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
cc: @eliottrosenberg this is a smaller RP I split from #7358. This one only touches the readout benchmarking but not pauli expectation calculation. |
NoureldinYosri
requested changes
Jun 27, 2025
| @@ -84,6 +101,79 @@ def _generate_readout_calibration_circuits( | |||
| return readout_calibration_circuits, random_bitstrings | |||
|
|
|||
|
|
|||
| def _generate_parameterized_readout_calibration_circuit_with_sweep( | |||
| qubits: list[ops.Qid], rng: np.random.Generator, num_random_bitstrings: int | |||
There was a problem hiding this comment.
traditionally rng should be the last input, same below
| qubits_set: set[ops.Qid] = set() | ||
| for circuit in input_circuits: | ||
| qubits_set.update(circuit.all_qubits()) | ||
| qubits_to_measure = [sorted(qubits_set)] |
There was a problem hiding this comment.
nit: this can be a single line
Suggested change
| qubits_to_measure = [sorted(qubits_set)] | |
| qubits_to_measure = [sorted(set(q for circuit in input_circuits for q in circuit.all_qubits())] |
cirq-core/cirq/contrib/shuffle_circuits/shuffle_circuits_with_readout_benchmarking.py
Show resolved
Hide resolved
cirq-core/cirq/contrib/shuffle_circuits/shuffle_circuits_with_readout_benchmarking.py
Show resolved
Hide resolved
cirq-core/cirq/contrib/shuffle_circuits/shuffle_circuits_with_readout_benchmarking.py
Show resolved
Hide resolved
cirq-core/cirq/contrib/paulistring/pauli_string_measurement_with_readout_mitigation.py
Outdated
Show resolved
Hide resolved
|
|
||
| def _determine_qubits_to_measure( | ||
| input_circuits: Sequence[circuits.Circuit], | ||
| qubits: Optional[Sequence[ops.Qid] | Sequence[Sequence[ops.Qid]]], |
There was a problem hiding this comment.
the type annotation for qubits is strange, why is a nested sequence?
There was a problem hiding this comment.
This is because each input circuit can have a corresponding qubit list to be measured. And since the function can accept a list of circuits, so it has a corresponding list[list[qid]], where each list[qid] matches a circuit.
cirq-core/cirq/contrib/shuffle_circuits/shuffle_circuits_with_readout_benchmarking.py
Outdated
Show resolved
Hide resolved
cirq-core/cirq/contrib/shuffle_circuits/shuffle_circuits_with_readout_benchmarking_test.py
Show resolved
Hide resolved
github-actions
bot
added
size: XL
NoureldinYosri
requested changes
Jul 29, 2025
cirq-core/cirq/contrib/shuffle_circuits/shuffle_circuits_with_readout_benchmarking.py
Outdated
Show resolved
Hide resolved
cirq-core/cirq/contrib/shuffle_circuits/shuffle_circuits_with_readout_benchmarking.py
Outdated
Show resolved
Hide resolved
cirq-core/cirq/contrib/shuffle_circuits/shuffle_circuits_with_readout_benchmarking.py
Show resolved
Hide resolved
cirq-core/cirq/contrib/shuffle_circuits/shuffle_circuits_with_readout_benchmarking.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requested by @NoureldinYosri, this pr is splited from #7358.
The pr adds a new function run_sweep_with_readout_benchmarking which runs the sweep circuits with readout error benchmarking (without shuffling).