Skip to content

Derive _kraus_ from _apply_channel_ #7434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 36 commits into from
Jul 22, 2025
Merged

Conversation

iamsusiep
Copy link
Contributor

@iamsusiep iamsusiep commented Jun 24, 2025

Add fallback strategy to the kraus protocol to obtain Kraus values from _apply_channel_.
Attempted as a very-last strategy, because it is computationally expensive.

Resolves #5921

@github-actions github-actions bot added the size: M 50< lines changed <250 label Jun 24, 2025
Copy link

codecov bot commented Jun 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.68%. Comparing base (bdcf704) to head (a72564a).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #7434    +/-   ##
========================================
  Coverage   98.68%   98.68%            
========================================
  Files        1091     1093     +2     
  Lines       96945    97179   +234     
========================================
+ Hits        95670    95904   +234     
  Misses       1275     1275            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@iamsusiep iamsusiep marked this pull request as ready for review June 24, 2025 16:00
@iamsusiep iamsusiep requested review from vtomole and a team as code owners June 24, 2025 16:00
@iamsusiep iamsusiep requested a review from senecameeks June 24, 2025 16:00
@iamsusiep
Copy link
Contributor Author

cc: @daxfohl

Copy link
Collaborator

@daxfohl daxfohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@iamsusiep
Copy link
Contributor Author

iamsusiep commented Jun 26, 2025

@pavoljuhas @vtomole @senecameeks PTAL, thanks!

@pavoljuhas pavoljuhas self-assigned this Jul 9, 2025
Copy link
Collaborator

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a couple of small changes.

@iamsusiep iamsusiep requested a review from pavoljuhas July 22, 2025 15:26
Copy link
Collaborator

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing this!

@pavoljuhas pavoljuhas added this pull request to the merge queue Jul 22, 2025
Merged via the queue into quantumlib:main with commit c09b3d0 Jul 22, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: M 50< lines changed <250
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Derive _kraus_ from _apply_channel_
3 participants