-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Derive _kraus_ from _apply_channel_ #7434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7434 +/- ##
========================================
Coverage 98.68% 98.68%
========================================
Files 1091 1093 +2
Lines 96945 97179 +234
========================================
+ Hits 95670 95904 +234
Misses 1275 1275 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cirq-core/cirq/contrib/paulistring/pauli_string_measurement_with_readout_mitigation.py
Outdated
Show resolved
Hide resolved
cc: @daxfohl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
@pavoljuhas @vtomole @senecameeks PTAL, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a couple of small changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contributing this!
Add fallback strategy to the kraus protocol to obtain Kraus values from
_apply_channel_
.Attempted as a very-last strategy, because it is computationally expensive.
Resolves #5921