Fixes #7384 : Made DecompositionContext non-optional in _decompose_with_context_ me… #7385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thods - Update type annotations in SupportsDecompose and SupportsDecomposeWithQubits protocols - Make context parameter non-optional in all _decompose_with_context_ implementations - Keep context optional in top-level decompose functions (decompose, decompose_once, decompose_once_with_qubits) - This change reflects that _decompose_with_context_ is never called without a valid DecompositionContext
Soham-47
changed the title
daxfohl
reviewed
May 29, 2025
| @@ -126,7 +126,7 @@ def _decompose_(self) -> DecomposeResult: | |||
| pass | |||
There was a problem hiding this comment.
There were a couple other places in this file too iirc, like some type definitions.
daxfohl
reviewed
May 29, 2025
cirq-core/cirq/ops/raw_types.py
Outdated
| @@ -832,7 +832,7 @@ def _decompose_(self) -> cirq.OP_TREE: | |||
| return self._decompose_with_context_() | |||
There was a problem hiding this comment.
Hmm, I think _decompose_ and _decompose_with_context_ should never both be implemented. If they are, then the protocol algorithm just runs twice and wastes CPU. So _decompose_ can be deleted in any file _decompose_with_context_ exists IIUC.
There was a problem hiding this comment.
You can also run check/pytest-changed-files locally to check the changes before pushing. check/mypy, check/format-incremental --apply, check/pylint-changed-files are also useful.
…nal functions - Made context parameter required in _DecomposeArgs and _try_op_decomposer - Kept context parameter optional in public API functions (decompose, decompose_once, etc.) - Updated type annotations to reflect that _decompose_with_context_ is always called with a valid context - Added proper null checks before using the context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7384 (comment)