Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5497: update IonQ docs to remove decompose_operation #7198

Merged
merged 3 commits into from
Mar 31, 2025

Conversation

mhucka
Copy link
Contributor

@mhucka mhucka commented Mar 28, 2025

Removed mention of decompose_operation.

Issue #5497 talks about updating the IonQ documentation to describe the use of transformers for compilation introduced in #5479. This commit does not address that. I think it would be better to leave IonQ doc additions to a separate PR.

mhucka and others added 2 commits March 28, 2025 10:43
Removed mention of `decompose_operation`.

Issue quantumlib#5497 talks about updating the IonQ documentation to describe
the use of transformers for compilation introduced in quantumlib#5479. This
commit does not address that.
@mhucka mhucka changed the title Fix #5497 Fix #5497: update IonQ docs to remove decompose_operation Mar 28, 2025
Copy link

codecov bot commented Mar 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.14%. Comparing base (4819570) to head (fe19efb).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7198   +/-   ##
=======================================
  Coverage   98.14%   98.14%           
=======================================
  Files        1100     1100           
  Lines       96147    96241   +94     
=======================================
+ Hits        94365    94458   +93     
- Misses       1782     1783    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mhucka mhucka marked this pull request as ready for review March 28, 2025 18:31
@mhucka mhucka requested review from dabacon, vtomole and a team as code owners March 28, 2025 18:31
@mhucka mhucka self-assigned this Mar 28, 2025
Replace and test the outdated example code (cirq.Circuit does not take
a `device` argument anymore).
Copy link
Collaborator

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after fixing the example code. Please check if it looks OK.

@mhucka
Copy link
Contributor Author

mhucka commented Mar 31, 2025

LGTM after fixing the example code. Please check if it looks OK.

I'm glad you reviewed that :-).

@mhucka mhucka added this pull request to the merge queue Mar 31, 2025
Merged via the queue into quantumlib:main with commit b140970 Mar 31, 2025
38 checks passed
@mhucka mhucka deleted the fix-5497 branch March 31, 2025 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants