Switch to unquoted type annotations part 1

[pavoljuhas]

No change in the effective code. A batch of 50 files.

Partially implements #1999

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.66%. Comparing base (56c13ab) to head (84dbc8b).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7193      +/-   ##
==========================================
- Coverage   98.66%   98.66%   -0.01%     
==========================================
  Files        1106     1106              
  Lines       95864    95904      +40     
==========================================
+ Hits        94580    94619      +39     
- Misses       1284     1285       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[daxfohl]

fwiw I hugely recommend getting familiar with https://docs.python.org/3/library/ast.html for this. Have a code generator write a sample script that takes a filename and uses the AST module to unquote all quoted type annotations in it. That'll give you a quick starting point, and then you can fiddle around with the script (manually, using breakpoints to understand what the AST library is doing; AI is only useful for generating the initial sample) to make it more precise.

I seem to have deleted the script I wrote originally for 1999, but it's pretty easy to use the AST to figure out which modules are imported from cirq vs third-party, and then use that information to determine which type annotations refer to cirq vs third-party, and only replace the cirq ones. One thing that I remember being challenging was internal generics like cirq.LinearDict[cirq.Qid]. IIRC the AST library didn't have an easy way to analyze those idiomatically. But there were only a few cases like that, and fortunately they could all be handled by two regexes that I just ran globally after everything else finished. The nice thing is the script can be as hacky as you want because you just throw it away at the end. But it's also nice to get experience with the library because the learning curve isn't super high, but it unlocks a ton of possibility once you get familiar with it.

[pavoljuhas]

fwiw I hugely recommend getting familiar with https://docs.python.org/3/library/ast.html for this.

Turns out ruff has already a fixable rule for this, namely quoted-annotation (UP037). I have also applied typing-only-first-party-import (TC001) to make annotation-only imports conditional.

Executed

ruff check --target-version=py310 --select=UP037 --fix
ruff check --target-version=py310 --select=TC001

[mhucka]

Discussed in Cirq Cynq 2025-04-02: also need to update the docs that describe how we want type annotations to be done. Not decided if we should make a separate issue or do the doc work as part of this PR.

[pavoljuhas]

Discussed in Cirq Cynq 2025-04-02: also need to update the docs that describe how we want type annotations to be done. Not decided if we should make a separate issue or do the doc work as part of this PR.

done separately in #7222

[mhucka]

Great!