-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/two fixed transmons qua #250
Conversation
…form/qua-libs into feature/two-fixed-transmons-qua
…qua-platform/qua-libs into feature/two-fixed-transmons-qua
…qua-platform/qua-libs into feature/two-fixed-transmons-qua
Hi guys, great work! I haven't reviewed the code, but since you worked together on it, would you still like a review? Regarding the merge conflict here, it looks like the renaming of I haven't pulled it to check. But, could you please locally:
|
Resolved the merge and pushed. LGTM! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
After two installations. Worked with Hiro on site -- need only merge-and-squash