Single- and two-qubit state and process tomography

[bornman-nick]

There are four experiment scripts in the Use Case 4 directory, carrying out single- and two-qubit quantum state tomography, as well as single- and two-qubit standard quantum process tomography. There is additionally a helper functions file (mainly constants and matplotlib functions useful for plotting), a license file (with a BSD-3 license, required by my employer), and a serialised pickle file, PMatrix2.pkl, which is needed to solve for the process matrix in the two-qubit process tomography case (since computing the contents of the file, which are constant, took an hour or two on my local machine).

[bornman-nick]

It looks like the check-python-formatting check is failing because I used a match statement in some function definitions in the helper functions module. Match statements only became available in python version 3.10, whereas it looks like the checker is assuming version 3.8.

The functions can be rewritten using lots of if ... elif statements, if that helps, but the resulting code would look more verbose.

[MichalGQM]

Hello, Yes, you’re right. I just replied on the "use-case for github 🙂 " thread. Best regards, [Logo]<https://www.quantum-machines.co/> [LinkedIn]<https://www.linkedin.com/company/quantumachines/> [Facebook] <https://www.facebook.com/quantummachines> [Github] <https://github.com/qua-platform/qua-libs> [Twitter] <https://twitter.com/QuantumQM> [YouTube] <https://www.youtube.com/c/QuantumMachines> Michal Goldenshtein CUSTOMER SUCCESS ENGINEER E: ***@***.******@***.***> W: quantum-machines.co<https://www.quantum-machines.co/>

…

________________________________ From: Nicholas Bornman ***@***.***> Sent: Wednesday, October 9, 2024 8:47 PM To: qua-platform/qua-libs ***@***.***> Cc: Michal Goldenshtein ***@***.***>; Review requested ***@***.***> Subject: Re: [qua-platform/qua-libs] Single- and two-qubit state and process tomography (PR #246) It looks like the check-python-formatting check is failing because I used a match statement in some function definitions in the helper functions module. Match statements only became available in python version 3.10, whereas it looks like the checker is assuming version 3.8. The functions can be rewritten using lots of if ... elif statements, if that helps, but the resulting code would look more verbose. — Reply to this email directly, view it on GitHub<#246 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AYBOSF3HOIHKMZ2UE2VU2KLZ2XMC5AVCNFSM6AAAAABNY67TVSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBTG4ZTENRYGE>. You are receiving this because your review was requested.Message ID: ***@***.***>

[yomach]

It looks like the check-python-formatting check is failing because I used a match statement in some function definitions in the helper functions module. Match statements only became available in python version 3.10, whereas it looks like the checker is assuming version 3.8.

The functions can be rewritten using lots of if ... elif statements, if that helps, but the resulting code would look more verbose.

Hi,
Can you try to rebase on latest version of main. We just recently updated Black, and I believe/hope it will solve it.
Alternatively, can you pip install black==24.8.0 and see if it works then?

[bornman-nick]

It looks like the check-python-formatting check is failing because I used a match statement in some function definitions in the helper functions module. Match statements only became available in python version 3.10, whereas it looks like the checker is assuming version 3.8.
The functions can be rewritten using lots of if ... elif statements, if that helps, but the resulting code would look more verbose.

Hi, Can you try to rebase on latest version of main. We just recently updated Black, and I believe/hope it will solve it. Alternatively, can you pip install black==24.8.0 and see if it works then?

Done

[yomach]

Okay, because we generally support Python 3.8, black automatically tries to adhere to that, and therefore, it fails.
We don't have an issue with use cases not working with older Python versions, so I don't want this to be a blocking issue. After a bit of googling I decided just to exclude the problematic file, I've pushed the change to your branch. Please run formatting using black 24.8.0
Also, please add to the readme file that it only works with Python 3.10 or above.

[bornman-nick]

Okay, because we generally support Python 3.8, black automatically tries to adhere to that, and therefore, it fails. We don't have an issue with use cases not working with older Python versions, so I don't want this to be a blocking issue. After a bit of googling I decided just to exclude the problematic file, I've pushed the change to your branch. Please run formatting using black 24.8.0 Also, please add to the readme file that it only works with Python 3.10 or above.

If the issue is emanating from the match case statements in the helper functions file, I'm happy to modify the functions. I'll probably get around to making the changes some time later today.

[KevinAVR]

Thank you @bornman-nick

[bornman-nick]

Hi @KevinAVR, @yomach. I think I've sorted out all issues with this pull request. Will you let me know if there's anything that I still need to do before it can be merged into the main branch?

[MichalGQM]

Hey,

I am sorry for the delay on my side. I just merged it and it is in the main branch :)

Thank you for contributing to the GitHub repository!!!