-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wide spectroscopy and Octave calibration parameters update #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheoLaudatQM
requested review from
a team and
paulQM
and removed request for
a team
October 16, 2024 09:21
pauljamet
reviewed
Oct 16, 2024
...ations/Superconducting/Single-Fixed-Transmon/04b_resonator_spectroscopy_wide_range_octave.py
Outdated
Show resolved
Hide resolved
pauljamet
reviewed
Oct 16, 2024
...ations/Superconducting/Single-Fixed-Transmon/04b_resonator_spectroscopy_wide_range_octave.py
Show resolved
Hide resolved
pauljamet
reviewed
Oct 16, 2024
...ations/Superconducting/Single-Fixed-Transmon/04b_resonator_spectroscopy_wide_range_octave.py
Outdated
Show resolved
Hide resolved
pauljamet
reviewed
Oct 16, 2024
...ations/Superconducting/Single-Fixed-Transmon/04b_resonator_spectroscopy_wide_range_octave.py
Outdated
Show resolved
Hide resolved
pauljamet
reviewed
Oct 16, 2024
...erconducting/Single-Fixed-Transmon/04c_resonator_spectroscopy_wide_range_octave_update_IF.py
Outdated
Show resolved
Hide resolved
pauljamet
reviewed
Oct 16, 2024
...ations/Superconducting/Single-Fixed-Transmon/04b_resonator_spectroscopy_wide_range_octave.py
Outdated
Show resolved
Hide resolved
pauljamet
reviewed
Oct 16, 2024
...erconducting/Single-Fixed-Transmon/04c_resonator_spectroscopy_wide_range_octave_update_IF.py
Outdated
Show resolved
Hide resolved
pauljamet
reviewed
Oct 16, 2024
...erconducting/Single-Fixed-Transmon/04c_resonator_spectroscopy_wide_range_octave_update_IF.py
Outdated
Show resolved
Hide resolved
pauljamet
reviewed
Oct 16, 2024
...erconducting/Single-Fixed-Transmon/04c_resonator_spectroscopy_wide_range_octave_update_IF.py
Outdated
Show resolved
Hide resolved
pauljamet
reviewed
Oct 17, 2024
...plications/Superconducting/Single-Fixed-Transmon/06d_qubit_spectroscopy_wide_range_octave.py
Outdated
Show resolved
Hide resolved
pauljamet
reviewed
Oct 17, 2024
...plications/Superconducting/Single-Fixed-Transmon/06d_qubit_spectroscopy_wide_range_octave.py
Outdated
Show resolved
Hide resolved
pauljamet
reviewed
Oct 17, 2024
...plications/Superconducting/Single-Fixed-Transmon/06d_qubit_spectroscopy_wide_range_octave.py
Outdated
Show resolved
Hide resolved
pauljamet
reviewed
Oct 17, 2024
.../Superconducting/Single-Fixed-Transmon/06e_qubit_spectroscopy_wide_range_octave_update_IF.py
Outdated
Show resolved
Hide resolved
pauljamet
reviewed
Oct 17, 2024
.../Superconducting/Single-Fixed-Transmon/06e_qubit_spectroscopy_wide_range_octave_update_IF.py
Outdated
Show resolved
Hide resolved
pauljamet
reviewed
Oct 17, 2024
.../Superconducting/Single-Fixed-Transmon/06e_qubit_spectroscopy_wide_range_octave_update_IF.py
Outdated
Show resolved
Hide resolved
paulQM
reviewed
Oct 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I tested it on the SA and everything seems fine 💯
I added some minor comments and suggestions, feel free to make changes or not.
Good job! 🙌
…smon/04b_resonator_spectroscopy_wide_range_octave.py Co-authored-by: pauljamet <[email protected]>
…smon/04b_resonator_spectroscopy_wide_range_octave.py Co-authored-by: pauljamet <[email protected]>
…smon/04b_resonator_spectroscopy_wide_range_octave.py Co-authored-by: pauljamet <[email protected]>
…smon/04c_resonator_spectroscopy_wide_range_octave_update_IF.py Co-authored-by: pauljamet <[email protected]>
…smon/04b_resonator_spectroscopy_wide_range_octave.py Co-authored-by: pauljamet <[email protected]>
…smon/04c_resonator_spectroscopy_wide_range_octave_update_IF.py Co-authored-by: pauljamet <[email protected]>
…smon/04c_resonator_spectroscopy_wide_range_octave_update_IF.py Co-authored-by: pauljamet <[email protected]>
…smon/04c_resonator_spectroscopy_wide_range_octave_update_IF.py Co-authored-by: pauljamet <[email protected]>
…smon/06d_qubit_spectroscopy_wide_range_octave.py Co-authored-by: pauljamet <[email protected]>
…smon/06d_qubit_spectroscopy_wide_range_octave.py Co-authored-by: pauljamet <[email protected]>
…smon/06d_qubit_spectroscopy_wide_range_octave.py Co-authored-by: pauljamet <[email protected]>
…smon/06e_qubit_spectroscopy_wide_range_octave_update_IF.py Co-authored-by: pauljamet <[email protected]>
…smon/06e_qubit_spectroscopy_wide_range_octave_update_IF.py Co-authored-by: pauljamet <[email protected]>
…smon/06e_qubit_spectroscopy_wide_range_octave_update_IF.py Co-authored-by: pauljamet <[email protected]>
paulQM
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example scripts for resonator and qubit spec when sweeping the LO in Python and the IF in QUA, showing how to update the octave correction parameters either in Python for each LO frequency, or in QUA for each LO frequency and some IFs