-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
init: Link List Columns #616
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some tidy up on doc's and question on alignment
|
||
export default { | ||
tags: ["autodocs"], | ||
title: "3. Components/Link Columns", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you align to vanilla naming. "3. Components/Link List/Link List (Columns)"
as there is also Link List component. https://www.designsystem.qld.gov.au/styles/typography#section__link-lists
Also add link to https://www.designsystem.qld.gov.au/components/link-columns-link-list
@@ -0,0 +1,13 @@ | |||
{{#if data.items}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is vanilla spec, unsure if we want to mimic?
{{! linked_list.hbs v0.0.1 }}
{{#if component.data.items}}
<ul{{#if component.data.metadata.id_field.value}} id="{{component.data.metadata.id_field.value}}"{{/if}} class="qld__link-columns{{#if component.data.type}} qld__link-columns--{{component.data.type}}{{/if}}">
{{#each component.data.items}}
<li {{#if component.data.all_link }} class="qld__link-columns__all-link"{{/if}}>
{{#if component.type }}
{{> (lookup component "type") this }}
{{else}}
{{{ this }}}
{{/if}}
</li>
{{/each}}
</ul>
{{/if}}
Init: Link List Columns