Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init: Link List Columns #616

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

init: Link List Columns #616

wants to merge 2 commits into from

Conversation

SenChung
Copy link
Contributor

@SenChung SenChung commented Feb 6, 2025

Init: Link List Columns

@SenChung SenChung added the enhancement New feature or request label Feb 6, 2025
@SenChung SenChung requested a review from elvishu February 6, 2025 04:05
@SenChung SenChung self-assigned this Feb 6, 2025
@SenChung SenChung requested a review from kat-yarrr February 6, 2025 23:49
@elvishu elvishu requested a review from jortronQGov February 9, 2025 23:31
Copy link
Member

@duttonw duttonw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some tidy up on doc's and question on alignment


export default {
tags: ["autodocs"],
title: "3. Components/Link Columns",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -0,0 +1,13 @@
{{#if data.items}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is vanilla spec, unsure if we want to mimic?

https://github.com/qld-gov-au/qgds-vanilla/blob/main/src/components/_global/css/link_columns/stories/link_columns.hbs

{{! linked_list.hbs v0.0.1 }}
{{#if component.data.items}}
    <ul{{#if component.data.metadata.id_field.value}} id="{{component.data.metadata.id_field.value}}"{{/if}} class="qld__link-columns{{#if component.data.type}} qld__link-columns--{{component.data.type}}{{/if}}">
    {{#each component.data.items}}
        <li  {{#if component.data.all_link }} class="qld__link-columns__all-link"{{/if}}>
          {{#if component.type }}
          {{> (lookup component "type") this }}
          {{else}}
          {{{ this }}}
          {{/if}}
      </li>
    {{/each}}
  </ul>
{{/if}}

@stvp-qld stvp-qld self-requested a review February 24, 2025 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants