Qoloe 667 qgdsb5 existing banner component #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps the storybook group with 11 updates in the / directory: | Package | From | To | | --- | --- | --- | | [@chromatic-com/storybook](https://github.com/chromaui/addon-visual-tests) | `1.6.1` | `3.2.2` | | [@storybook/addon-a11y](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/a11y) | `8.2.1` | `8.4.2` | | [@storybook/addon-essentials](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/essentials) | `8.2.1` | `8.4.2` | | [@storybook/addon-interactions](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/interactions) | `8.2.1` | `8.4.2` | | [@storybook/addon-links](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/links) | `8.2.1` | `8.4.2` | | [@storybook/addon-themes](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/themes) | `8.2.1` | `8.4.2` | | [@storybook/blocks](https://github.com/storybookjs/storybook/tree/HEAD/code/lib/blocks) | `8.2.1` | `8.4.2` | | [@storybook/cli](https://github.com/storybookjs/storybook/tree/HEAD/code/lib/cli) | `8.2.1` | `8.4.2` | | [@storybook/html](https://github.com/storybookjs/storybook/tree/HEAD/code/renderers/html) | `8.2.1` | `8.4.2` | | [@storybook/html-vite](https://github.com/storybookjs/storybook/tree/HEAD/code/frameworks/html-vite) | `8.2.1` | `8.4.2` | | [@storybook/test](https://github.com/storybookjs/storybook/tree/HEAD/code/lib/test) | `8.2.1` | `8.4.2` | Updates `@chromatic-com/storybook` from 1.6.1 to 3.2.2 - [Release notes](https://github.com/chromaui/addon-visual-tests/releases) - [Changelog](https://github.com/chromaui/addon-visual-tests/blob/main/CHANGELOG.md) - [Commits](chromaui/addon-visual-tests@v1.6.1...v3.2.2) Updates `@storybook/addon-a11y` from 8.2.1 to 8.4.2 - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v8.4.2/code/addons/a11y) Updates `@storybook/addon-essentials` from 8.2.1 to 8.4.2 - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v8.4.2/code/addons/essentials) Updates `@storybook/addon-interactions` from 8.2.1 to 8.4.2 - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v8.4.2/code/addons/interactions) Updates `@storybook/addon-links` from 8.2.1 to 8.4.2 - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v8.4.2/code/addons/links) Updates `@storybook/addon-themes` from 8.2.1 to 8.4.2 - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v8.4.2/code/addons/themes) Updates `@storybook/blocks` from 8.2.1 to 8.4.2 - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v8.4.2/code/lib/blocks) Updates `@storybook/cli` from 8.2.1 to 8.4.2 - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v8.4.2/code/lib/cli) Updates `@storybook/html` from 8.2.1 to 8.4.2 - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v8.4.2/code/renderers/html) Updates `@storybook/html-vite` from 8.2.1 to 8.4.2 - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v8.4.2/code/frameworks/html-vite) Updates `@storybook/manager-api` from 8.2.1 to 8.4.2 - [Release notes](https://github.com/storybookjs/storybook/releases) - [Commits](https://github.com/storybookjs/storybook/commits/v8.4.2/code/lib/manager-api) Updates `@storybook/test` from 8.2.1 to 8.4.2 - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v8.4.2/code/lib/test) Updates `@storybook/theming` from 8.2.1 to 8.4.2 - [Release notes](https://github.com/storybookjs/storybook/releases) - [Commits](https://github.com/storybookjs/storybook/commits/v8.4.2/code/lib/theming) Updates `chromatic` from 11.5.5 to 11.18.0 - [Release notes](https://github.com/chromaui/chromatic-cli/releases) - [Changelog](https://github.com/chromaui/chromatic-cli/blob/main/CHANGELOG.md) - [Commits](chromaui/chromatic-cli@v11.5.5...v11.18.0) Updates `storybook` from 8.2.1 to 8.4.2 - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v8.4.2/code/lib/cli) --- updated-dependencies: - dependency-name: "@chromatic-com/storybook" dependency-type: direct:development update-type: version-update:semver-major dependency-group: storybook - dependency-name: "@storybook/addon-a11y" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: storybook - dependency-name: "@storybook/addon-essentials" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: storybook - dependency-name: "@storybook/addon-interactions" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: storybook - dependency-name: "@storybook/addon-links" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: storybook - dependency-name: "@storybook/addon-themes" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: storybook - dependency-name: "@storybook/blocks" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: storybook - dependency-name: "@storybook/cli" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: storybook - dependency-name: "@storybook/html" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: storybook - dependency-name: "@storybook/html-vite" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: storybook - dependency-name: "@storybook/manager-api" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: storybook - dependency-name: "@storybook/test" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: storybook - dependency-name: "@storybook/theming" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: storybook - dependency-name: chromatic dependency-type: direct:development update-type: version-update:semver-minor dependency-group: storybook - dependency-name: storybook dependency-type: direct:development update-type: version-update:semver-minor dependency-group: storybook ... Signed-off-by: dependabot[bot] <[email protected]>
…op/storybook-26ad0ca50b Bump the storybook group across 1 directory with 15 updates
duttonw
requested changes
Feb 12, 2025
| /** | ||
| * Banner with Advance Banner | ||
| */ | ||
| export const AdvanceBanner = { |
There was a problem hiding this comment.
can you split the story out since vanilla has 3 versions of banner, (simple, basic, intermediate, advanced)
https://qld-gov-au.github.io/qgds-vanilla/storybook/?path=/docs/components-banner-banner-advanced--overview
https://github.com/qld-gov-au/qgds-vanilla/blob/main/src/components/banner_advanced/stories/bannerAdvanced.stories.js
Banner/Banner (Advanced)
| @@ -155,6 +155,17 @@ export const WithCallToAction = { | |||
| }, | |||
| } | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
add figma link to advanced banner
https://www.figma.com/design/qKsxl3ogIlBp7dafgxXuCA/QLD-GOV-DDS?node-id=7287-691763
cross link to https://www.designsystem.qld.gov.au/components/banners#section__advanced-banner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes need for Storybook to include the Advance Banner Variation