fix: CTA first button remove left margin #527
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| .banner-image { | ||
| display: none; | ||
| } | ||
| display: none; |
There was a problem hiding this comment.
Why display none? We lose the image if we do.
There was a problem hiding this comment.
@ghazal-salehi the banner-image rule was there in the develop branch.
I am not sure why this rule is there, as I did not add it.
The only change that I make was on line 105 &:first-of-type
ghazal-salehi
changed the base branch from
develop
to
QOLOE-585-Graduate-Portal-DSBS5
duttonw
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: CTA first button remove left margin
-> This aligns the first button with the rest of the components content
-> This will only apply to the first child btn class within the banner cta