Skip to content

Fix minor typos #971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 12, 2025
Merged

Fix minor typos #971

merged 6 commits into from
Aug 12, 2025

Conversation

q-inho
Copy link
Contributor

@q-inho q-inho commented Jul 24, 2025

Summary

Fix typo

  • Remove repetitive words (the the -> the)
  • Fix minor Grammar
  • is -> if
  • qiskit.circuit.library.rea_amplitudes -> qiskit.circuit.library.real_amplitudes

@woodsp-ibm
Copy link
Member

Tests are failing for 2 reasons. 1 you need to fix which is the copyrights need updating to 2025.

Wrong Copyright Year:'qiskit_machine_learning/algorithms/objective_functions.py': Current:'# (C) Copyright IBM 2021, 2024.' Correct:'# (C) Copyright IBM 2021, 2025.'
Wrong Copyright Year:'qiskit_machine_learning/algorithms/classifiers/neural_network_classifier.py': Current:'# (C) Copyright IBM 2021, 2024.' Correct:'# (C) Copyright IBM 2021, 2025.'
Wrong Copyright Year:'qiskit_machine_learning/neural_networks/init.py': Current:'# (C) Copyright IBM 2019, 2024.' Correct:'# (C) Copyright IBM 2019, 2025.'
Wrong Copyright Year:'qiskit_machine_learning/kernels/trainable_kernel.py': Current:'# (C) Copyright IBM 2022, 2023.' Correct:'# (C) Copyright IBM 2022, 2025.'
0 files have utf8 headers.
4 of 194 files with copyright header have wrong years.

You can run make copyright in the root of the project to have them automatically fixed rather than manually editing them.

The 2nd is that one test is failing here more generally and #970 was done a short while ago to fix that - which it does - once that is merged then this will be able to pass.

@q-inho
Copy link
Contributor Author

q-inho commented Jul 24, 2025

Thank you for guidance. I just updated the copyright year.

@coveralls
Copy link

coveralls commented Aug 8, 2025

Pull Request Test Coverage Report for Build 16911475370

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.818%

Totals Coverage Status
Change from base Build 16911109844: 0.0%
Covered Lines: 4530
Relevant Lines: 4988

💛 - Coveralls

Copy link
Collaborator

@OkuyanBoga OkuyanBoga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks

@OkuyanBoga OkuyanBoga merged commit d36f4f8 into qiskit-community:main Aug 12, 2025
16 checks passed
@q-inho q-inho deleted the typo branch August 12, 2025 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants