Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Opaque Pointer spec updates #43

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

swernli
Copy link
Contributor

@swernli swernli commented Jan 30, 2025

This PR crates a v0.2 version of the spec that updates all the language and signatures to use opaque pointers, which became the default pointer style starting in LLVM 17. It also updates the Base and Adaptive profile specifications in-place, revving the qir_major_version in code samples to correspond to the breaking change.

A few open questions:

  1. Should the v0.1 -> v0.2 update even take place? While here are some classical runtimes that support these functions, most efforts have focused on the profiles.
  2. Would the profiles benefit from duplication into v1 vs v2 rather than in-place update?
  3. Should the discussions and proposals from the working group and the GitHub issue (see below) be captured somewhere in the spec itself?

See #30 (comment) for context and motivation behind this proposed change.

@swernli
Copy link
Contributor Author

swernli commented Mar 12, 2025

@microsoft-github-policy-service rerun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants