Implement support for x86 macOS (i386)#1648
Open
ciciplusplus wants to merge 40 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Which kind of PR do you create?
Coding convention?
Extra tests?
Changelog?
Target branch?
One last thing
Known issues
qtoolwas changed to add/dev/urandomfs mapping. Probably it should be another cli option to define a list of guest to host fs mappingql_syscall_thread_fast_set_cthread_selfimplementation for x86 is probably incorrect (i just copied 64 variant)commpageimplemented with jump call tomy_prefixed host functions. Could be not the cleanest solution, open to refactoring suggestions/other approaches.Additional fixes
Below fixes are not necessary related to x86 support and could be merged separately if preferred:
ql_syscall_write_nocancelto return number of bytes writtenql_syscall_preadmmap2withmmapon macOSDependencies
rootfs/x86_macosshould have following files:Linker
Dylibs
Run example