Updated to support changes in mg-scripts for multiple config. #78
Conversation
| @@ -0,0 +1,91 @@ | |||
| { | |||
There was a problem hiding this comment.
Why do we need this and the other json here? I thought they could be taken from mg-scripts ... no?
There was a problem hiding this comment.
no. these are to support the unittests, which require initializing a pipeline object and hence a sample configuration file and configuration_profiles directory with sample profiles.
| @@ -0,0 +1,265 @@ | |||
| #!/bin/bash -l | |||
There was a problem hiding this comment.
Why is this file now needed in the tests vs. just leaving it in the templates?
There was a problem hiding this comment.
it's much less time-consuming to simply load the expected value from a file and compare it with the observed results rather than keep trying to make point changes to a list of strings that are often split to placate flake8. We really do modify that batch script often, at least currently.
There was a problem hiding this comment.
however, I thought we were not adding tests that compared this file in a tests ... no?
There was a problem hiding this comment.
we're not adding new tests but this was an existing test. I could replace the test for one that simply checks for the existence of a job-script in the output and maybe checks the first few lines, but that seems a step backwards.
charles-cowart
changed the title
|
PR is ostensibly done. Reference to mg-scripts needs to point back to master once the latest mg-scripts PR has been reviewed, approved, and merged. Latest push didn't trigger CI, but includes the fixes to resolve all outstanding issues observed in CI. |
qp-klp configuration-related code/unittests updated to support multiple configurations and the latest changes in mg-scripts.
There is a single test (test_replicates) that needs some additional updates.