-
Notifications
You must be signed in to change notification settings - Fork 79
Tornado fetch file from central handler #3483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Tornado fetch file from central handler #3483
Conversation
…o file delivery method respectively
… to avoid lazy client from downloading whole BASE_DATA_DIR
…alsoDirs Tornado fetch file from central handler also dirs
…alsoDirs_debug Tornado fetch file from central handler also dirs debug
…delete add ability to delete files/dirs through API, but only in qiita test …
|
Yeah, I think that "hack" in qtp-sequencing was the first time I encountered the issue of running the same tests multiple times in the same environment and having leftover files - I think that's the same issue with my current PR in qtp-job-output-folder but I need to confirm. Now, before putting all these ideas together I actually encountered this issue again in qp-pacbio and fixed like this. I think this deserves a call; I'll email you to coordinate. |
This the accompanying PR to qiita-spots/qiita_client#60
In short: I've extended fetch and push from only files to also directories. In test mode, objects can also be deleted. Depending on the route of API calls (through nginx = 8383 OR directly to tornado = 2117x), file delivery is handled differently to make us of nginx's much faster transfer capability
More elaborate:
/apitest/reset/endpoint (and also others). However, this only works properly if qiita master is addressed. Tests therefore do not speak against nginx (port 8383) but directly with the master instance (port 21174). However, when sending files, I relied on delivery through nginx. If requests go directly to master, the file content will be empty - and tests fail. With PR Tornado fetch file from central handler #3483 the according endpoint checks if a request was made through nginx (and then uses it's fast mechanism to deliver the file) or directly to the tornado instance (which now can also send the file in a much slower fashion). Should be fast enough for testing.