Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: hardcoded skbio metrics to temporarily work around NaN to 0 implementation #63

Merged
merged 7 commits into from
May 2, 2024

Conversation

hagenjp
Copy link
Contributor

@hagenjp hagenjp commented Apr 30, 2024

python 3.9 updates.

  1. removed all references to 'kulsinski' as it has been removed from the valid beta diversity metrics in skbio (skbio issue #2009)
  2. switch out kulsinski for euclidean for the usage example

@hagenjp hagenjp force-pushed the Language-python39-update branch from f364089 to 9eeb6ff Compare May 1, 2024 17:52
@hagenjp hagenjp changed the title removed kulsinski from valid beta metrics and usage examples, matching skbio changes hardcoded skbio metrics to temporarily work around NaN to 0 implementation May 1, 2024
@hagenjp
Copy link
Contributor Author

hagenjp commented May 1, 2024

  1. added hardcoded metrics that were previously accessed from skbio
  2. implemented corresponding tests for these metrics sourced from skbio

@hagenjp hagenjp requested a review from lizgehret May 2, 2024 00:15
@lizgehret
Copy link
Member

tested locally, these changes look reasonable. thanks @hagenjp and @cherman2!

@lizgehret lizgehret merged commit 983125e into dev May 2, 2024
2 of 4 checks passed
@lizgehret lizgehret changed the title hardcoded skbio metrics to temporarily work around NaN to 0 implementation MAINT: hardcoded skbio metrics to temporarily work around NaN to 0 implementation May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

2 participants