Skip to content

Disable tonic default features who introduces outdated axum #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Disable tonic default features who introduces outdated axum #213

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ categories = ["database", "api-bindings"]
keywords = ["qdrant", "vector-search", "search-engine", "client", "grpc"]

[dependencies]
tonic = { version = "0.12.3", features = ["tls", "tls-roots", "gzip"] }
tonic = { version = "0.12.3", default-features = false, features = ["codegen", "prost", "tls", "tls-roots", "gzip"] }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason for not enabling channel as well?

https://docs.rs/tonic/latest/tonic/#feature-flags

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, just because it builds and passes all tests. I actually don't know what channel does internally and how it may change user experience or performance. axum is only introduced by router so it's safe to add channel back if necessary.

prost = "0.13.3"
prost-types = "0.13.3"
anyhow = "1.0.89"
Expand Down