Updated player deletion code to accommodate tables that do not use the column name citizenid #1187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated `Delete character` code to handle database tables where primary key is not `citizenid` Changed `playertables` format to handle any primary key Updated `DeleteCharater()` and `ForceDeleteCharater()` SQL commands
…e column name citizenid Updated player deletion code in server/player.lua to accommodate tables that do not use the column name citizenid Many scripts use other column names to store the citizenid but contain data that should be deleted upon character deletion. This leads to excess data build up in the database that is no longer needed and currently requires manual effort to clean out the database.
|
This PR has had 60 days of inactivity & will close within 7 days |
tlsharkie
commented
May 14, 2025
tlsharkie
commented
May 14, 2025
Removed trailing whitespace to pass lint tests
|
updated code and removed trailing whitespaces to pass lint tests |
|
This includes tables that do not exist in qbcore |
Z3rio
suggested changes
Aug 1, 2025
Comment on lines
+554
to
+565
| { table = 'bank_cards', key = 'identifier' }, | ||
| { table = 'bank_history', key = 'identifier' }, | ||
| { table = 'casino_players', key = 'identifier' }, | ||
| { table = 'cd_garage_privategarage', key = 'identifier' }, | ||
| { table = 'inventory_clothes', key = 'identifier' }, | ||
| { table = 'lation_detecting', key = 'identifier' }, | ||
| { table = 'm_hunting', key = 'identifier' }, | ||
|
|
||
| --Tables with other citizenid labels | ||
| { table = 'bank_process', key = 'owner' }, | ||
| { table = 'mail_accounts', key = 'owner' }, | ||
| { table = 'lation_chopshop', key = 'player_identifier' }, |
There was a problem hiding this comment.
None of these exist on a normal/default qbcore server.
There was a problem hiding this comment.
I am fine with you remvoving the non-qbcore tables from the official push.
Please use the addtional tables as a reference for how to use the new format.
There was a problem hiding this comment.
I am fine with you remvoving the non-qbcore tables from the official push. Please use the addtional tables as a reference for how to use the new format.
This is your PR, so I cant remove them for you. Sorry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated player deletion code in
server/player.luato accommodate tables that do not use the column namecitizenid.Many scripts use other column names to store the
citizenidbut contain data that should be deleted upon character deletion. This leads to excess data build up in the database that is no longer needed and currently requires manual effort to clean out the database.New format for
playertablesnow contains table and key variables (primary key column name)and updated SQL commands in
DeleteCharacterandForceDeleteCharacterto handle variable column namesChecklist