Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes misidentification of source as an identifier #1165

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

PickleModifications
Copy link

Description

This fixes misidentification of string numbers (e.g. "1", "2", "3"), and correctly converts them to source numbers for indexing rather than interpreting it as an identifier.

Checklist

  • I have personally loaded this code into an updated qbcore project and checked all of its functionality.
  • My code fits the style guidelines.
  • My PR fits the contribution guidelines.

Copy link
Contributor

@Cocodrulo Cocodrulo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@SinisterDevelopment
Copy link

cant not merge do to Branch is out of date with QBC branch. Please update and resubmit for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants