Do not access private Renderer._actors
property
#682
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
BackgroundPlotter
accesses a private variable of 3rd party imported class, i.e.Renderer._actors
. But there is no need to access a private property here sinceRenderer.actors
simply returnsRenderer._actors
already anyway.See
Renderer.actors
source:https://github.com/pyvista/pyvista/blob/5be64528b73a970df364b4e2dd7ebfa0b62e9b64/pyvista/plotting/renderer.py#L818-L821
The underlying implementation for
Renderer._actors
is being modified by pyvista/pyvista#7184 and the access to a private variable here bypyvistaqt
is causing integration tests to fail unexpectedly.EDIT: This was addressed upstream by implementing an
_actors.items()
method, so this change is not strictly needed by pyvista/pyvista#7184, but I still think access to private vars should be avoided here