Update footer: show only single address #425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, only the billing address was updated.
Footer changes: * Show only one address. * Show download links as a list, make their icon clickable. * Move download links to their own column. The change included small tweaks to CSS, so a version query string was added to prevent stale caches.
honzajavorek
approved these changes
Aug 5, 2024
| Ječná 507/6<br> | ||
| 12000 Prague<br> | ||
| Czech Republic, EU | ||
| directions: *address |
| @@ -10,35 +10,28 @@ claim: | |||
| Service non-profit organization of the Czech<br> | |||
| [Python](https://python.cz/en/) programming language user group | |||
|
|
|||
| # Billing address is not used in the template, but it was part of the JSON API response. | |||
| # Keeping it does not hurt us, therefore we should keep it for compatibility. | |||
There was a problem hiding this comment.
Už jsem úplně zapomněl, že tam je „API“ 😅 Nejsem si teda jistý, zda se k něčemu někde používá...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Při první úpravě jsem se zaměřil hlavně na tu fakturační adresu a tu druhou nezměnil. Patičku jsem tedy upravil, aby tam byla jen jedna adresa. Zároveň jsem jí o trošku přeskládal, aby to vypadalo lépe, udělal jsem ikonky u souborů ke stažení klikatelné a vyladil bílé místo na mobilu.
Nová podoba patičky: