Skip to content

Conversation

@pnuu
Copy link
Member

@pnuu pnuu commented Oct 17, 2025

This PR refactors the pyspectral.utils module.

  • Closes #xxxx
  • Tests added
  • Tests passed: Passes pytest pyspectral
  • Passes flake8 pyspectral
  • Fully documented
  • Add your name to AUTHORS.md if not there already

@pnuu pnuu requested review from adybbroe and mraspaud October 17, 2025 10:45
@pnuu pnuu self-assigned this Oct 17, 2025
@codecov
Copy link

codecov bot commented Oct 17, 2025

Codecov Report

❌ Patch coverage is 93.39623% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.35%. Comparing base (d4ea15a) to head (c2fe336).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
pyspectral/utils.py 93.39% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #265      +/-   ##
==========================================
+ Coverage   90.28%   90.35%   +0.06%     
==========================================
  Files          22       22              
  Lines        2523     2541      +18     
==========================================
+ Hits         2278     2296      +18     
  Misses        245      245              
Flag Coverage Δ
unittests 90.35% <93.39%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@adybbroe
Copy link
Collaborator

Very nice work @pnuu , thanks!
Do we have test coverage of all this? Or do you want/need help there?

@pnuu
Copy link
Member Author

pnuu commented Oct 22, 2025

Codecov shows that the code in the if isinstance(det_rsr[key], dict) branch moved to the new _collect_responses(det_rsr, key, det_wavenumbers) function isn't covered. The other part is the untouched logger setup. If you have ideas how to test the former, please do 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants