Skip to content

Do not clear UncachedCompile between graph executions #9282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 5, 2025
Merged

Do not clear UncachedCompile between graph executions #9282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7ca0d3e
do not clear UncachedCompile between node runs
haifeng-jin Jun 2, 2025
7b7cbae
bug fix
haifeng-jin Jun 4, 2025
eaa0d92
add unit tests
haifeng-jin Jun 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions test/dynamo/test_bridge.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,6 +303,20 @@ def foo(t):
t = torch.randint(0, 5, (3,), device=device)
self._compile_and_check(foo, (t,))

def test_metrics_preserved(self):
metrics.clear_counters()
torch_xla._XLAC._xla_increment_counter('UncachedCompile', 3)
torch_xla._XLAC._xla_increment_counter('DynamoExtractCompiledGraph', 4)

model = BasicModule()
graph_module = torch.fx.symbolic_trace(model)
collector = bridge.UnsupportedNodesCollector(graph_module)
collector.run(torch.randn(1), torch.randn(1))

self.assertEqual(metrics.counter_value('UncachedCompile'), 3)
self.assertEqual(metrics.counter_value('DynamoExtractCompiledGraph'), 4)
metrics.clear_counters()


if __name__ == "__main__":
from torch._dynamo.test_case import run_tests
Expand Down
4 changes: 4 additions & 0 deletions torch_xla/_dynamo/dynamo_bridge.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -646,6 +646,7 @@ def run_node(self, n: torch.fx.Node):
# We need to restore this metric count later, so save it in a separate variable
dynamo_extract_graph_helper_metric_count = metrics.counter_value(
'DynamoExtractCompiledGraph')
uncached_compile_metric_count = metrics.counter_value('UncachedCompile')

metrics.clear_counters()
result = super().run_node(n)
Expand Down Expand Up @@ -684,6 +685,9 @@ def all_tensors_on_xla_device(value):
# Restore this metric counter
torch_xla._XLAC._xla_increment_counter(
'DynamoExtractCompiledGraph', dynamo_extract_graph_helper_metric_count)
if uncached_compile_metric_count is not None:
torch_xla._XLAC._xla_increment_counter('UncachedCompile',
uncached_compile_metric_count)

return result

Expand Down