Skip to content

[CircleCI] Delete vs2017 and vs2019 packages #5501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packaging/build_cmake.sh
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ if [[ "$OSTYPE" == "msys" ]]; then
pip install dataclasses
fi

setup_visual_studio_constraint
setup_junit_results_folder

if [[ "$(uname)" == Darwin ]]; then
Expand Down
1 change: 0 additions & 1 deletion packaging/build_conda.sh
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ setup_env 0.13.0
export SOURCE_ROOT_DIR="$PWD"
setup_conda_pytorch_constraint
setup_conda_cudatoolkit_constraint
setup_visual_studio_constraint
setup_junit_results_folder

# nvidia channel included for cudatoolkit >= 11 however for 11.5 we use conda-forge
Expand Down
9 changes: 0 additions & 9 deletions packaging/pkg_helpers.bash
Original file line number Diff line number Diff line change
Expand Up @@ -373,15 +373,6 @@ setup_conda_cudatoolkit_plain_constraint() {
fi
}

# Build the proper compiler package before building the final package
setup_visual_studio_constraint() {
if [[ "$OSTYPE" == "msys" ]]; then
export VSTOOLCHAIN_PACKAGE=vs$VC_YEAR
conda build $CONDA_CHANNEL_FLAGS --no-anaconda-upload packaging/$VSTOOLCHAIN_PACKAGE
cp packaging/$VSTOOLCHAIN_PACKAGE/conda_build_config.yaml packaging/torchvision/conda_build_config.yaml
fi
}

setup_junit_results_folder() {
if [[ "$CI" == "true" ]]; then
export CONDA_PYTORCH_BUILD_RESULTS_DIRECTORY="${SOURCE_ROOT_DIR}/build_results/results.xml"
Expand Down
6 changes: 2 additions & 4 deletions packaging/torchvision/conda_build_config.yaml
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
channel_sources:
- pytorch-nightly,pytorch,defaults
blas_impl:
- mkl # [x86_64]
c_compiler:
- vs2017 # [win]
- vs2019 # [win]
cxx_compiler:
- vs2017 # [win]
- vs2019 # [win]
python:
- 3.7
# This differs from target_platform in that it determines what subdir the compiler
Expand Down
44 changes: 0 additions & 44 deletions packaging/vs2017/activate.bat

This file was deleted.

23 changes: 0 additions & 23 deletions packaging/vs2017/conda_build_config.yaml

This file was deleted.

29 changes: 0 additions & 29 deletions packaging/vs2017/install_activate.bat

This file was deleted.

49 changes: 0 additions & 49 deletions packaging/vs2017/install_runtime.bat

This file was deleted.

24 changes: 0 additions & 24 deletions packaging/vs2017/meta.yaml

This file was deleted.

44 changes: 0 additions & 44 deletions packaging/vs2019/activate.bat

This file was deleted.

23 changes: 0 additions & 23 deletions packaging/vs2019/conda_build_config.yaml

This file was deleted.

29 changes: 0 additions & 29 deletions packaging/vs2019/install_activate.bat

This file was deleted.

49 changes: 0 additions & 49 deletions packaging/vs2019/install_runtime.bat

This file was deleted.

24 changes: 0 additions & 24 deletions packaging/vs2019/meta.yaml

This file was deleted.

Loading