Skip to content

mark fsdp1 tutorial as deprecated #3478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

weifengpy
Copy link
Contributor

@weifengpy weifengpy commented Jul 20, 2025

pytorch doc audit: only fsdp2 tutorial links to fsdp1 tutorial

Screenshot 2025-07-20 at 15 23 42

Description

Checklist

  • The issue that is being fixed is referred in the description (see above "Fixes #ISSUE_NUMBER")
  • Only one issue is addressed in this pull request
  • Labels from the issue that this PR is fixing are added to this pull request
  • No unnecessary issues are included into this pull request.

only fsdp2 tutorial links to fsdp1 tutorial
Copy link

pytorch-bot bot commented Jul 20, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3478

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 5db20c8 with merge base 064b69a (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@weifengpy weifengpy requested a review from mori360 July 20, 2025 22:24
@meta-cla meta-cla bot added the cla signed label Jul 20, 2025
@weifengpy weifengpy requested a review from svekars July 20, 2025 22:24
Copy link
Contributor

@svekars svekars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we already have a note on line 6 that it's deprecated

@weifengpy
Copy link
Contributor Author

abandon this pr as fsdp1 is already marked as deprecated

@weifengpy weifengpy closed this Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants