-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Update the profiler_recipe tutorial #3386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3386
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit d41c61a with merge base 06f9c4b ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Hi @sekyondaMeta and @svekars , Hi team! I'm working on enhancing the PyTorch Profiler tutorial to better cover memory profiling capabilities. I'd like to take a two-phase approach: Complete the coding examplesI want to focus on getting the code examples right first. Since I'm still learning the deeper aspects of the profiler, I'd really appreciate guidance on what additional coding examples should be included beyond what's currently in the tutorial. Could you review this as a draft and let me know: |
@albanD Can you offer some guidance here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better to show the timeline tool described in the blogpost you link rather than just the attribution part I think
@krishnakalyan3 See the comment from albanD |
yes @sekyondaMeta , I will be working on this today. |
Fixes #3112
Description
Checklist
cc @aaronenyeshi @chaekit