(torchx/runopt) Allow runopt type to be builtin list[str] and dict[str,str] #1093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D78767495 |
tonykao8080
reviewed
Jul 24, 2025
torchx/specs/api.py
Outdated
| @@ -789,6 +789,48 @@ class runopt: | |||
| is_required: bool | |||
| help: str | |||
|
|
|||
| @property | |||
| def is_type_list(self) -> bool: | |||
There was a problem hiding this comment.
should the property be renamed to 'is_type_list_of_str' since the check ensure the elements are of type str?
There was a problem hiding this comment.
Agreed, updated
tonykao8080
reviewed
Jul 24, 2025
torchx/specs/api.py
Outdated
| return self.opt_type in (List[str], list[str]) | ||
|
|
||
| @property | ||
| def is_type_dict(self) -> bool: |
There was a problem hiding this comment.
similar to is_type_list, should this be more explicitly named as type_dict_of_str?
There was a problem hiding this comment.
Same as above, updated
…r,str] (#1093) Summary: As title, supports `list[str]` and `dict[str, str]` types in runopt. Updated testcases to better cover potential type casting issues. Differential Revision: D78767495
facebook-github-bot
force-pushed
the
export-D78767495
branch
from
531b9a3 to
98974c5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78767495 |
kiukchung
approved these changes
Jul 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
As title, supports
list[str]anddict[str, str]types in runopt.Updated testcases to better cover potential type casting issues.
Differential Revision: D78767495