Skip to content

set pg names #1910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

set pg names #1910

wants to merge 2 commits into from

Conversation

@tushar00jain
Copy link
Contributor

@tushar00jain tushar00jain commented Oct 17, 2025 •
edited
Loading

This was referenced Oct 17, 2025
Draft
Draft
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 17, 2025
@tushar00jain tushar00jain force-pushed the pr1910 branch 2 times, most recently from c0c66dd to e3bb189 Compare October 17, 2025 21:21
@tushar00jain tushar00jain mentioned this pull request Oct 17, 2025
Open
@tushar00jain tushar00jain force-pushed the pr1910 branch 3 times, most recently from 170103b to d38bf9f Compare October 22, 2025 17:52
@tushar00jain
fix setting ft state dicts when ft checkpointing is disabled
267f201 
Summary:
- when ft dataloader checkpointing is disabled, we also don't set the ft state
- make it so that when ft checkpointing is disabled, we still set the state dict so that model, optimizer etc. can be recovered from a different replica
@tushar00jain
set pg names
6626ecf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tianyu-l tianyu-l Awaiting requested review from tianyu-l tianyu-l will be requested when the pull request is marked ready for review tianyu-l is a code owner

@fegin fegin Awaiting requested review from fegin fegin will be requested when the pull request is marked ready for review fegin is a code owner

@wwwjn wwwjn Awaiting requested review from wwwjn wwwjn will be requested when the pull request is marked ready for review wwwjn is a code owner

@wconstab wconstab Awaiting requested review from wconstab wconstab will be requested when the pull request is marked ready for review wconstab is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@tushar00jain