[llama4][auxiliary-loss-free load balancing] update expert_bias without backward hooks #1304
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
finalize_model_grads_func
attribute in TrainSpec.finalize_model_grads_func
toupdate_router_expert_bias
for MoE models.finalize_model_grads_func
is called AFTER gradient accumulation steps.enable_tp2ep
is reserved for [llama4] enable expert parallel on the same device mesh as tp (tp2ep) #1269Reasons:
expert_bias
on each microbatches during gradient accumulation.cc @tianyu-l