Improve Quantization Setup Prompts and Doc #1537
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/1537
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 New Failures, 2 Cancelled JobsAs of commit 70239cc with merge base 0299a37 ( NEW FAILURES - The following jobs have failed:
CANCELLED JOBS - The following jobs were cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
| exit 1 | ||
| fi | ||
|
|
||
| if [[ "$LINK_TORCHAO_OPS" == "ON" ]]; then | ||
| if [ ! -d "${TORCHCHAT_ROOT}/torchao-build" ]; then | ||
| echo "Directory ${TORCHCHAT_ROOT}/torchao-build does not exist." | ||
| echo "Make sure you run clone_torchao" | ||
| echo "Make sure you run bash torchchat/utils/scripts/clone_torchao.sh" |
There was a problem hiding this comment.
nit: don't need to specify bash
There was a problem hiding this comment.
I was thinking that, if we have to let users run this, with clone_torchao they might not know how to run it.
| @@ -149,6 +149,7 @@ From the torchchat root directory, run | |||
| bash torchchat/utils/scripts/build_torchao_ops.sh | |||
| ``` | |||
|
|
|||
| Note that before running it, you must first clone torchao with `bash torchchat/utils/scripts/clone_torchao.sh` if you have not done so already. | |||
There was a problem hiding this comment.
clone_torchao is called as part of the install_requirements, so it might be better for us to remind users to call that first
There was a problem hiding this comment.
Do you mean ./install/install_requirements.sh, I don't see torchao is cloned to the path that build_torchao_ops.sh uses.
|
The ET failure is a separate pin error that I'm throwing up a fix for |
Currently we don't prompt people to clone torchao first before running
bash torchchat/utils/scripts/build_torchao_ops.sh. We can improve the prompts and doc similar to what we already have forbash torchchat/utils/scripts/build_native.sh et link_torchao_ops.cc @Jack-Khuu @byjlw