Skip to content

runners: Remove SSM deletion from terminateRunner #6934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 16, 2025

Conversation

seemethere
Copy link
Member

This is super-ceded by our addition of an expiration policy to our SSM parameters. I also think that this was somewhat causing us to be slow.

See:

This is super-ceded by our addition of an expiration policy to our SSM
parameters. I also think that this was somewhat causing us to be slow.

Signed-off-by: Eli Uriegas <[email protected]>
Copy link

vercel bot commented Jul 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
torchci ⬜️ Ignored (Inspect) Visit Preview Jul 15, 2025 11:41pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 15, 2025
@seemethere seemethere requested a review from a team July 15, 2025 23:24
@seemethere
Copy link
Member Author

seemethere commented Jul 15, 2025

Currently updating tests

Tests have been updated

Signed-off-by: Eli Uriegas <[email protected]>
Signed-off-by: Eli Uriegas <[email protected]>
@seemethere seemethere merged commit 456e399 into main Jul 16, 2025
6 checks passed
@seemethere seemethere deleted the seemethere/remove_the_removal_of_ssm_parameters branch July 16, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants