runners: Add scaleCycle lambda to reuse runners #6892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seemethere
added a commit
that referenced
this pull request
Jul 7, 2025
This lambda will attempt to reuse runners that have finished jobs that are sitting idle. Plan is to have this run in AWS on a cron. The functionality within this lambda will eventually replace the tryReuseRunner function in scale-up.ts. Signed-off-by: Eli Uriegas <[email protected]> ghstack-source-id: bc13e21 ghstack-comment-id: 3046547816 Pull-Request: #6892
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
facebook-github-bot
added
the
CLA Signed
seemethere
added a commit
that referenced
this pull request
Jul 7, 2025
This lambda will attempt to reuse runners that have finished jobs that are sitting idle. Plan is to have this run in AWS on a cron. The functionality within this lambda will eventually replace the tryReuseRunner function in scale-up.ts. Signed-off-by: Eli Uriegas <[email protected]> ghstack-source-id: debc427 ghstack-comment-id: 3046547816 Pull-Request: #6892 Signed-off-by: Eli Uriegas <[email protected]>
This was referenced Jul 7, 2025
ZainRizvi
reviewed
Jul 14, 2025
| console.info(`Reusing runner ${runner.instanceId} for ${getRepoKey(repo)}`); | ||
| } | ||
|
|
||
| await tryReuseRunner(runnerInputParameters, metrics); |
There was a problem hiding this comment.
This might be a little too high level of a function to be invoking here.
In this loop you've already identified a candidate list of runners that are probably ready to be scaled down.
tryReuseRunner however looses context on what those candidates were and on each loop it'll starts from scratch again to find a potential runner it can scale down, starting with asking EC2 to list all runners of this runner type.
What do you think about adding a refactor to do something like the following:
- Extract the logic the logic to determine if a runner is safe to be shut down into one function, use that to determine the exact list of runners we want to refresh here
- Extract the logic to do the scale down (plus validations) into a separate function that takes in an explicit runner id. Pass the runners you find here into that list
Goal is to not end up looping over the same instances over and over again during a single ScaleCycle invocation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lambda will attempt to reuse runners that have finished jobs that are sitting idle. Plan is to have this run in AWS on a cron.
The functionality within this lambda will eventually replace the tryReuseRunner function in scale-up.ts.
Note
This does not implement terraform yet, I'm trying to break up these PRs into smaller pieces to make it easier to review
Signed-off-by: Eli Uriegas [email protected]