Pin to SHA for actions outside of PyTorch #6573
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zxiiro is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
facebook-github-bot
added
the
CLA Signed
|
The OIDC test failures are hitting the same issue I identified here pytorch/pytorch#151456 (comment) I think OIDC rules need to be updated to support PRs from forked repos. |
seemethere
approved these changes
Apr 30, 2025
ZainRizvi
approved these changes
Apr 30, 2025
Pin actions from repos external to the PyTorch project to their shasums for security. This is a best practice as Git tags are not immutable. https://openssf.org/blog/2024/08/12/mitigating-attack-vectors-in-github-workflows/ Signed-off-by: Thanh Ha <[email protected]>
zxiiro
force-pushed
the
zxiiro/pin-actions
branch
from
06a7696 to
78fbb5f
Compare
|
Oh yeah this PR was failing because I pushed to my fork. Let me reopen this from test-infra. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pin actions from repos external to the PyTorch project to their shasums for security. This is a best practice as Git tags are not immutable.
https://openssf.org/blog/2024/08/12/mitigating-attack-vectors-in-github-workflows/