Skip to content

Use custom tag prefix in linux_job_v2 #6559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Use custom tag prefix in linux_job_v2 #6559

wants to merge 4 commits into from

Conversation

clee2000
Copy link
Contributor

@clee2000 clee2000 commented Apr 23, 2025 •
edited
Loading

No description provided.

@vercel Vercel
Copy link

vercel bot commented Apr 23, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
torchci ⬜️ Ignored (Inspect) Visit Preview Apr 29, 2025 8:05pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 23, 2025
@clee2000 clee2000 force-pushed the csl/linux_job_v2_custom_docker_tag branch from 05459db to e911fd2 Compare April 23, 2025 17:59
@clee2000 clee2000 requested a review from a team April 25, 2025 20:31
@clee2000 clee2000 marked this pull request as ready for review April 25, 2025 20:31
@clee2000 clee2000 force-pushed the csl/linux_job_v2_custom_docker_tag branch from 14a3685 to 3e70b9f Compare April 29, 2025 18:23
huydhn
huydhn approved these changes Apr 29, 2025
View reviewed changes
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Although I think we should also do a quick test on PyTorch with this change to confirm that calculate-docker-images still works

@clee2000
Copy link
Contributor Author

Closing this in favor of #6586 which does basically the same thing but is better named

@clee2000 clee2000 closed this Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zxiiro zxiiro zxiiro approved these changes

@huydhn huydhn huydhn approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@clee2000 @zxiiro @huydhn @facebook-github-bot