Update CMake to 3.25 #6443
Update CMake to 3.25 #6443
Conversation
|
@cyyever is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
facebook-github-bot
added
the
CLA Signed
|
@q10 Can you help review? |
|
@cyyever looks good to me, hopefully it can be landed soon |
|
@q10 I have no permission. Because you are more familiar with the maintainers here, could you push it? |
|
Started tests |
|
@wdvr Could we remove py3.8 jobs because they are not required by PyTorch? |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
I have approveed CI run and the test job is running now https://github.com/pytorch/test-infra/actions/runs/14003548921. Because Also, someone from Dev Infra would need to run Packer to bake the new Windows AMI to confirm that the change works on Windows. |
|
@huydhn MacOS 12 reached EOL, and its test failures are unrelated. |
|
@clee2000 Can you help check this PR about CMake updating. |
|
Hi @cyyever we would need to rebuild and retest windows AMI if we want to include the change in |
| @@ -28,7 +28,7 @@ inputs: | |||
| description: Default packages to install | |||
| required: false | |||
| type: string | |||
| default: "cmake=3.22 ninja=1.10 pkg-config=0.29 wheel=0.37" | |||
There was a problem hiding this comment.
Should we update cmake to cmake=3.25 rather then cmake>=3.25 ? Latest cmake 4 broke a lot of build earlier this week
There was a problem hiding this comment.
In some platforms condo doesn't have exactly cmake=3.25 and specifying that would have installation failure. I think Cmake 4 compatibility is another issue that should be resolved independently.
In preparation for updating PyTorch's CMake version. See pytorch/pytorch#130522