-
-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move contrib metrics files #3220
Conversation
@leej3 can you check why https://github.com/pytorch/ignite/actions/runs/8451157627/job/23149407599?pr=3220 is failing? |
looking through it now... |
1617863
to
a3dfd96
Compare
I refactored the commits to make it easier to spot the modifications to the files that were in ignite.contrib.metrics and are now in ignite.metrics. I can't spot what might be causing the failure of the TPU tests though. The diff is small but persists across reruns:
|
this test fails intermittently. the main difference between this branch and master is the a chance difference in the order the tests are run which reliably triggers the failure.
79ef36f
to
f08dfd3
Compare
I didn't discover anything especially useful from ssh-ing into the tpu tests machine. Some of the tests in ignite/metrics/regression fail intermittently on master and this branch. The failures are deterministic but failures are triggered by things like the order the tests are run. For example running I have adjusted the tolerance of the comparisons to make it pass more reliably. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, John! LGTM
Same migration pattern as #3204:
references are updated as part of this PR to avoid failures in building the docs